1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401
//! Handles transform propagation, scale updates, and [`ColliderParent`] updates for colliders.
//!
//! See [`ColliderHierarchyPlugin`].
use crate::{
prelude::*,
prepare::{match_any, PrepareSet},
sync::ancestor_marker::{AncestorMarker, AncestorMarkerPlugin},
};
use bevy::{
ecs::{intern::Interned, schedule::ScheduleLabel},
prelude::*,
};
use narrow_phase::NarrowPhaseSet;
/// A plugin for managing the collider hierarchy and related updates.
///
/// - Updates [`ColliderParent`].
/// - Propagates [`ColliderTransform`].
///
/// This plugin requires Bevy's `HierarchyPlugin` and that colliders have the `ColliderMarker` component,
/// which is added automatically for colliders if the [`ColliderBackendPlugin`] is enabled.
pub struct ColliderHierarchyPlugin {
schedule: Interned<dyn ScheduleLabel>,
}
impl ColliderHierarchyPlugin {
/// Creates a [`ColliderHierarchyPlugin`] with the schedule that is used for running the [`PhysicsSchedule`].
///
/// The default schedule is `PostUpdate`.
pub fn new(schedule: impl ScheduleLabel) -> Self {
Self {
schedule: schedule.intern(),
}
}
}
impl Default for ColliderHierarchyPlugin {
fn default() -> Self {
Self {
schedule: PostUpdate.intern(),
}
}
}
#[derive(SystemSet, Clone, Copy, Debug, PartialEq, Eq, Hash)]
struct MarkColliderAncestors;
impl Plugin for ColliderHierarchyPlugin {
fn build(&self, app: &mut App) {
// Mark ancestors of colliders with `AncestorMarker<ColliderMarker>`.
// This is used to speed up `ColliderTransform` propagation by skipping
// trees that have no colliders.
app.add_plugins(
AncestorMarkerPlugin::<ColliderMarker>::new(self.schedule)
.add_markers_in_set(MarkColliderAncestors),
);
app.configure_sets(
self.schedule,
MarkColliderAncestors
.after(PrepareSet::InitColliders)
.before(PrepareSet::PropagateTransforms),
);
// Update collider parents.
app.add_systems(
self.schedule,
update_collider_parents
.after(PrepareSet::InitColliders)
.before(PrepareSet::Finalize),
);
// Run transform propagation if new colliders without rigid bodies have been added.
// The `PreparePlugin` should handle transform propagation for new rigid bodies.
app.add_systems(
self.schedule,
(
crate::sync::sync_simple_transforms_physics,
crate::sync::propagate_transforms_physics,
)
.chain()
.run_if(match_any::<(Added<ColliderMarker>, Without<RigidBody>)>)
.in_set(PrepareSet::PropagateTransforms)
.ambiguous_with_all(),
);
// Propagate `ColliderTransform`s if there are new colliders.
// Only traverses trees with `AncestorMarker<ColliderMarker>`.
app.add_systems(
self.schedule,
(
propagate_collider_transforms,
update_child_collider_position,
)
.chain()
.run_if(match_any::<Added<ColliderMarker>>)
.after(PrepareSet::InitTransforms)
.before(PrepareSet::Finalize),
);
let physics_schedule = app
.get_schedule_mut(PhysicsSchedule)
.expect("add PhysicsSchedule first");
physics_schedule
.add_systems(handle_rigid_body_removals.after(PhysicsStepSet::SpatialQuery));
// Propagate `ColliderTransform`s before narrow phase collision detection.
// Only traverses trees with `AncestorMarker<ColliderMarker>`.
physics_schedule.add_systems(
(
propagate_collider_transforms,
update_child_collider_position,
)
.chain()
.in_set(NarrowPhaseSet::First),
);
}
fn finish(&self, app: &mut App) {
if !app.is_plugin_added::<HierarchyPlugin>() {
warn!("`ColliderHierarchyPlugin` requires Bevy's `HierarchyPlugin` to function. If you don't need collider hierarchies, consider disabling this plugin.",);
}
}
}
/// Updates [`ColliderParent`] for descendant colliders of [`RigidBody`] entities.
///
/// The [`ColliderBackendPlugin`] handles collider parents for colliders that are
/// on the same entity as the rigid body.
#[allow(clippy::type_complexity)]
fn update_collider_parents(
mut commands: Commands,
mut bodies: Query<Entity, (With<RigidBody>, With<AncestorMarker<ColliderMarker>>)>,
children: Query<&Children>,
mut child_colliders: Query<
Option<&mut ColliderParent>,
(With<ColliderMarker>, Without<RigidBody>),
>,
) {
for entity in &mut bodies {
for child in children.iter_descendants(entity) {
if let Ok(collider_parent) = child_colliders.get_mut(child) {
if let Some(mut collider_parent) = collider_parent {
collider_parent.0 = entity;
} else {
commands.entity(child).insert((
ColliderParent(entity),
// TODO: This probably causes a one frame delay. Compute real value?
ColliderTransform::default(),
PreviousColliderTransform::default(),
));
}
}
}
}
}
/// Updates colliders when the rigid bodies they were attached to have been removed.
fn handle_rigid_body_removals(
mut commands: Commands,
colliders: Query<(Entity, &ColliderParent), Without<RigidBody>>,
bodies: Query<(), With<RigidBody>>,
removals: RemovedComponents<RigidBody>,
) {
// Return if no rigid bodies have been removed
if removals.is_empty() {
return;
}
for (collider_entity, collider_parent) in &colliders {
// If the body associated with the collider parent entity doesn't exist,
// remove ColliderParent and ColliderTransform.
if !bodies.contains(collider_parent.get()) {
commands.entity(collider_entity).remove::<(
ColliderParent,
ColliderTransform,
PreviousColliderTransform,
)>();
}
}
}
#[allow(clippy::type_complexity)]
pub(crate) fn update_child_collider_position(
mut colliders: Query<
(
&ColliderTransform,
&mut Position,
&mut Rotation,
&ColliderParent,
),
Without<RigidBody>,
>,
parents: Query<(&Position, &Rotation), (With<RigidBody>, With<Children>)>,
) {
for (collider_transform, mut position, mut rotation, parent) in &mut colliders {
let Ok((parent_pos, parent_rot)) = parents.get(parent.get()) else {
continue;
};
position.0 = parent_pos.0 + parent_rot * collider_transform.translation;
#[cfg(feature = "2d")]
{
*rotation = *parent_rot * collider_transform.rotation;
}
#[cfg(feature = "3d")]
{
*rotation = (parent_rot.0 * collider_transform.rotation.0)
.normalize()
.into();
}
}
}
// `ColliderTransform` propagation should only be continued if the child
// is a collider or is a `AncestorMarker<ColliderMarker>`.
type ShouldPropagate = Or<(With<AncestorMarker<ColliderMarker>>, With<ColliderMarker>)>;
/// Updates [`ColliderTransform`]s based on entity hierarchies. Each transform is computed by recursively
/// traversing the children of each rigid body and adding their transforms together to form
/// the total transform relative to the body.
///
/// This is largely a clone of `propagate_transforms` in `bevy_transform`.
#[allow(clippy::type_complexity)]
pub(crate) fn propagate_collider_transforms(
mut root_query: Query<
(Entity, Ref<Transform>, &Children),
(Without<Parent>, With<AncestorMarker<ColliderMarker>>),
>,
collider_query: Query<
(
Ref<Transform>,
Option<&mut ColliderTransform>,
Option<&Children>,
),
(With<Parent>, ShouldPropagate),
>,
parent_query: Query<(Entity, Ref<Transform>, Has<RigidBody>, Ref<Parent>), ShouldPropagate>,
) {
root_query.par_iter_mut().for_each(
|(entity, transform, children)| {
for (child, child_transform, is_child_rb, parent) in parent_query.iter_many(children) {
assert_eq!(
parent.get(), entity,
"Malformed hierarchy. This probably means that your hierarchy has been improperly maintained, or contains a cycle"
);
let changed = transform.is_changed() || parent.is_changed();
let parent_transform = ColliderTransform::from(*transform);
let child_transform = ColliderTransform::from(*child_transform);
let scale = parent_transform.scale * child_transform.scale;
// SAFETY:
// - `child` must have consistent parentage, or the above assertion would panic.
// Since `child` is parented to a root entity, the entire hierarchy leading to it is consistent.
// - We may operate as if all descendants are consistent, since `propagate_collider_transform_recursive` will panic before
// continuing to propagate if it encounters an entity with inconsistent parentage.
// - Since each root entity is unique and the hierarchy is consistent and forest-like,
// other root entities' `propagate_collider_transform_recursive` calls will not conflict with this one.
// - Since this is the only place where `collider_query` gets used, there will be no conflicting fetches elsewhere.
unsafe {
propagate_collider_transforms_recursive(
if is_child_rb {
ColliderTransform {
scale,
..default()
}
} else {
ColliderTransform {
translation: parent_transform.scale * child_transform.translation,
rotation: child_transform.rotation,
scale,
}
},
&collider_query,
&parent_query,
child,
changed,
);
}
}
},
);
}
/// Recursively computes the [`ColliderTransform`] for `entity` and all of its descendants
/// by propagating transforms.
///
/// This is largely a clone of `propagate_recursive` in `bevy_transform`.
///
/// # Panics
///
/// If `entity`'s descendants have a malformed hierarchy, this function will panic occur before propagating
/// the transforms of any malformed entities and their descendants.
///
/// # Safety
///
/// - While this function is running, `collider_query` must not have any fetches for `entity`,
/// nor any of its descendants.
/// - The caller must ensure that the hierarchy leading to `entity`
/// is well-formed and must remain as a tree or a forest. Each entity must have at most one parent.
#[allow(clippy::type_complexity)]
unsafe fn propagate_collider_transforms_recursive(
transform: ColliderTransform,
collider_query: &Query<
(
Ref<Transform>,
Option<&mut ColliderTransform>,
Option<&Children>,
),
(With<Parent>, ShouldPropagate),
>,
parent_query: &Query<(Entity, Ref<Transform>, Has<RigidBody>, Ref<Parent>), ShouldPropagate>,
entity: Entity,
mut changed: bool,
) {
let children = {
// SAFETY: This call cannot create aliased mutable references.
// - The top level iteration parallelizes on the roots of the hierarchy.
// - The caller ensures that each child has one and only one unique parent throughout the entire
// hierarchy.
//
// For example, consider the following malformed hierarchy:
//
// A
// / \
// B C
// \ /
// D
//
// D has two parents, B and C. If the propagation passes through C, but the Parent component on D points to B,
// the above check will panic as the origin parent does match the recorded parent.
//
// Also consider the following case, where A and B are roots:
//
// A B
// \ /
// C D
// \ /
// E
//
// Even if these A and B start two separate tasks running in parallel, one of them will panic before attempting
// to mutably access E.
let Ok((transform_ref, collider_transform, children)) =
(unsafe { collider_query.get_unchecked(entity) })
else {
return;
};
changed |= transform_ref.is_changed();
if changed {
if let Some(mut collider_transform) = collider_transform {
if *collider_transform != transform {
*collider_transform = transform;
}
}
}
children
};
let Some(children) = children else { return };
for (child, child_transform, is_rb, parent) in parent_query.iter_many(children) {
assert_eq!(
parent.get(), entity,
"Malformed hierarchy. This probably means that your hierarchy has been improperly maintained, or contains a cycle"
);
let child_transform = ColliderTransform::from(*child_transform);
let scale = transform.scale * child_transform.scale;
// SAFETY: The caller guarantees that `collider_query` will not be fetched
// for any descendants of `entity`, so it is safe to call `propagate_collider_transforms_recursive` for each child.
//
// The above assertion ensures that each child has one and only one unique parent throughout the
// entire hierarchy.
unsafe {
propagate_collider_transforms_recursive(
if is_rb {
ColliderTransform { scale, ..default() }
} else {
ColliderTransform {
translation: transform.transform_point(child_transform.translation),
#[cfg(feature = "2d")]
rotation: transform.rotation * child_transform.rotation,
#[cfg(feature = "3d")]
rotation: Rotation(transform.rotation.0 * child_transform.rotation.0),
scale,
}
},
collider_query,
parent_query,
child,
changed || parent.is_changed(),
);
}
}
}
// TODO: Add thorough tests for propagation. It's pretty error-prone and changes are risky.