1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449
use super::InitialMesh;
use super::{ConvexHullError, TriangleFacet};
use crate::math::Real;
use crate::transformation::convex_hull_utils::indexed_support_point_nth;
use crate::transformation::convex_hull_utils::{indexed_support_point_id, normalize};
use crate::utils;
use na::{self, Point3};
/// Computes the convex hull of a set of 3d points.
pub fn convex_hull(points: &[Point3<Real>]) -> (Vec<Point3<Real>>, Vec<[u32; 3]>) {
try_convex_hull(points).unwrap()
}
/// Computes the convex hull of a set of 3d points.
pub fn try_convex_hull(
points: &[Point3<Real>],
) -> Result<(Vec<Point3<Real>>, Vec<[u32; 3]>), ConvexHullError> {
if points.is_empty() {
return Ok((Vec::new(), Vec::new()));
}
// print_buildable_vec("input", points);
let mut normalized_points = points.to_vec();
let _ = normalize(&mut normalized_points[..]);
let mut undecidable_points = Vec::new();
let mut silhouette_loop_facets_and_idx = Vec::new();
let mut removed_facets = Vec::new();
let mut triangles;
match super::try_get_initial_mesh(points, &mut normalized_points[..], &mut undecidable_points)?
{
InitialMesh::Facets(facets) => {
triangles = facets;
}
InitialMesh::ResultMesh(vertices, indices) => {
return Ok((vertices, indices));
}
}
let mut i = 0;
while i != triangles.len() {
silhouette_loop_facets_and_idx.clear();
if !triangles[i].valid || triangles[i].affinely_dependent {
i += 1;
continue;
}
// TODO: use triangles[i].furthest_point instead.
let pt_id = indexed_support_point_id(
&triangles[i].normal,
&normalized_points[..],
triangles[i].visible_points[..].iter().copied(),
);
if let Some(point) = pt_id {
triangles[i].valid = false;
removed_facets.clear();
removed_facets.push(i);
for j in 0usize..3 {
// println!(">> loop;");
compute_silhouette(
triangles[i].adj[j],
triangles[i].indirect_adj_id[j],
point,
&mut silhouette_loop_facets_and_idx,
&normalized_points[..],
&mut removed_facets,
&mut triangles[..],
);
}
// In some degenerate cases (because of float rounding problems), the silhouette may:
// 1. Contain self-intersections (i.e. a single vertex is used by more than two edges).
// 2. Contain multiple disjoint (but nested) loops.
fix_silhouette_topology(
&normalized_points,
&mut silhouette_loop_facets_and_idx,
&mut removed_facets,
&mut triangles[..],
)?;
// Check that the silhouette is valid.
// TODO: remove this debug code.
// {
// for (facet, id) in &silhouette_loop_facets_and_idx {
// assert!(triangles[*facet].valid);
// assert!(!triangles[triangles[*facet].adj[*id]].valid);
// }
// }
if silhouette_loop_facets_and_idx.is_empty() {
// Due to inaccuracies, the silhouette could not be computed
// (the point seems to be visible from… every triangle).
let mut any_valid = false;
for triangle in &triangles[i + 1..] {
if triangle.valid && !triangle.affinely_dependent {
any_valid = true;
}
}
if any_valid {
return Err(ConvexHullError::InternalError(
"Internal error: exiting an unfinished work.",
));
}
// TODO: this is very harsh.
triangles[i].valid = true;
break;
}
attach_and_push_facets(
&silhouette_loop_facets_and_idx[..],
point,
&normalized_points[..],
&mut triangles,
&removed_facets[..],
&mut undecidable_points,
);
// println!("Verifying facets at iteration: {}, k: {}", i, k);
// for i in 0..triangles.len() {
// if triangles[i].valid {
// super::check_facet_links(i, &triangles[..]);
// }
// }
}
i += 1;
}
let mut idx = Vec::new();
for facet in triangles.iter() {
if facet.valid {
idx.push([
facet.pts[0] as u32,
facet.pts[1] as u32,
facet.pts[2] as u32,
]);
}
}
let mut points = points.to_vec();
utils::remove_unused_points(&mut points, &mut idx[..]);
// super::check_convex_hull(&points, &idx);
Ok((points, idx))
}
fn compute_silhouette(
facet: usize,
indirect_id: usize,
point: usize,
out_facets_and_idx: &mut Vec<(usize, usize)>,
points: &[Point3<Real>],
removed_facets: &mut Vec<usize>,
triangles: &mut [TriangleFacet],
) {
if triangles[facet].valid {
if !triangles[facet].order_independent_can_be_seen_by_point(point, points) {
// println!("triangles: {}, valid: true, keep: true", facet);
// println!(
// "Taking edge: [{}, {}]",
// triangles[facet].second_point_from_edge(indirect_id),
// triangles[facet].first_point_from_edge(indirect_id)
// );
out_facets_and_idx.push((facet, indirect_id));
} else {
triangles[facet].valid = false; // The facet must be removed from the convex hull.
removed_facets.push(facet);
// println!("triangles: {}, valid: true, keep: false", facet);
compute_silhouette(
triangles[facet].adj[(indirect_id + 1) % 3],
triangles[facet].indirect_adj_id[(indirect_id + 1) % 3],
point,
out_facets_and_idx,
points,
removed_facets,
triangles,
);
compute_silhouette(
triangles[facet].adj[(indirect_id + 2) % 3],
triangles[facet].indirect_adj_id[(indirect_id + 2) % 3],
point,
out_facets_and_idx,
points,
removed_facets,
triangles,
);
}
} else {
// println!("triangles: {}, valid: false, keep: false", facet);
}
}
fn fix_silhouette_topology(
points: &[Point3<Real>],
out_facets_and_idx: &mut Vec<(usize, usize)>,
removed_facets: &mut Vec<usize>,
triangles: &mut [TriangleFacet],
) -> Result<(), ConvexHullError> {
// TODO: don't allocate this everytime.
let mut workspace = vec![0; points.len()];
let mut needs_fixing = false;
// NOTE: we wore with the second_point_from_edge instead
// of the first one, because when we traverse the silhouette
// we see the second edge point before the first.
for (facet, adj_id) in &*out_facets_and_idx {
let p = triangles[*facet].second_point_from_edge(*adj_id);
workspace[p] += 1;
if workspace[p] > 1 {
needs_fixing = true;
}
}
// We detected a topological problem, i.e., we have
// multiple loops.
if needs_fixing {
// First, we need to know which loop is the one we
// need to keep.
let mut loop_start = 0;
for (facet, adj_id) in &*out_facets_and_idx {
let p1 = points[triangles[*facet].second_point_from_edge(*adj_id)];
let p2 = points[triangles[*facet].first_point_from_edge(*adj_id)];
let supp = indexed_support_point_nth(
&(p2 - p1),
points,
out_facets_and_idx
.iter()
.map(|(f, ai)| triangles[*f].second_point_from_edge(*ai)),
)
.ok_or(ConvexHullError::MissingSupportPoint)?;
let selected = &out_facets_and_idx[supp];
if workspace[triangles[selected.0].second_point_from_edge(selected.1)] == 1 {
// This is a valid point to start with.
loop_start = supp;
break;
}
}
let mut removing = None;
let old_facets_and_idx = std::mem::take(out_facets_and_idx);
for i in 0..old_facets_and_idx.len() {
let facet_id = (loop_start + i) % old_facets_and_idx.len();
let (facet, adj_id) = old_facets_and_idx[facet_id];
match removing {
Some(p) => {
let p1 = triangles[facet].second_point_from_edge(adj_id);
if p == p1 {
removing = None;
}
}
_ => {
let p1 = triangles[facet].second_point_from_edge(adj_id);
if workspace[p1] > 1 {
removing = Some(p1);
}
}
}
if removing.is_some() {
if triangles[facet].valid {
triangles[facet].valid = false;
removed_facets.push(facet);
}
} else {
out_facets_and_idx.push((facet, adj_id));
}
// // Debug
// {
// let p1 = triangles[facet].second_point_from_edge(adj_id);
// let p2 = triangles[facet].first_point_from_edge(adj_id);
// if removing.is_some() {
// print!("/{}, {}\\ ", p1, p2);
// } else {
// print!("[{}, {}] ", p1, p2);
// }
// }
}
// println!();
}
Ok(())
}
fn attach_and_push_facets(
silhouette_loop_facets_and_idx: &[(usize, usize)],
point: usize,
points: &[Point3<Real>],
triangles: &mut Vec<TriangleFacet>,
removed_facets: &[usize],
undecidable: &mut Vec<usize>,
) {
// The silhouette is built to be in CCW order.
let mut new_facets = Vec::with_capacity(silhouette_loop_facets_and_idx.len());
// Create new facets.
let mut adj_facet: usize;
let mut indirect_id: usize;
for silhouette_loop_facets_and_id in silhouette_loop_facets_and_idx {
adj_facet = silhouette_loop_facets_and_id.0;
indirect_id = silhouette_loop_facets_and_id.1;
// print!(
// "[{}, {}] ",
// triangles[adj_facet].second_point_from_edge(indirect_id),
// triangles[adj_facet].first_point_from_edge(indirect_id)
// );
let facet = TriangleFacet::new(
point,
triangles[adj_facet].second_point_from_edge(indirect_id),
triangles[adj_facet].first_point_from_edge(indirect_id),
points,
);
new_facets.push(facet);
}
// println!();
// Link the facets together.
for i in 0..silhouette_loop_facets_and_idx.len() {
let prev_facet = if i == 0 {
triangles.len() + silhouette_loop_facets_and_idx.len() - 1
} else {
triangles.len() + i - 1
};
let (middle_facet, middle_id) = silhouette_loop_facets_and_idx[i];
let next_facet = triangles.len() + (i + 1) % silhouette_loop_facets_and_idx.len();
new_facets[i].set_facets_adjascency(prev_facet, middle_facet, next_facet, 2, middle_id, 0);
assert!(!triangles[triangles[middle_facet].adj[middle_id]].valid); // Check that we are not overwriting a valid link.
triangles[middle_facet].adj[middle_id] = triangles.len() + i; // The future id of curr_facet.
triangles[middle_facet].indirect_adj_id[middle_id] = 1;
}
// Assign to each facets some of the points which can see it.
// TODO: refactor this with the others.
for curr_facet in removed_facets.iter() {
for visible_point in triangles[*curr_facet].visible_points.iter() {
if points[*visible_point] == points[point] {
continue;
}
let mut furthest = usize::MAX;
let mut furthest_dist = 0.0;
for (i, curr_facet) in new_facets.iter_mut().enumerate() {
if !curr_facet.affinely_dependent {
let distance = curr_facet.distance_to_point(*visible_point, points);
if distance > furthest_dist {
furthest = i;
furthest_dist = distance;
}
}
}
if furthest != usize::MAX && new_facets[furthest].can_see_point(*visible_point, points)
{
new_facets[furthest].add_visible_point(*visible_point, points);
}
// If none of the facet can be seen from the point, it is implicitly
// deleted because it won't be referenced by any facet.
}
}
// Try to assign collinear points to one of the new facets.
let mut i = 0;
while i != undecidable.len() {
let mut furthest = usize::MAX;
let mut furthest_dist = 0.0;
let undecidable_point = undecidable[i];
for (j, curr_facet) in new_facets.iter_mut().enumerate() {
if curr_facet.can_see_point(undecidable_point, points) {
let distance = curr_facet.distance_to_point(undecidable_point, points);
if distance > furthest_dist {
furthest = j;
furthest_dist = distance;
}
}
}
if furthest != usize::MAX {
new_facets[furthest].add_visible_point(undecidable_point, points);
let _ = undecidable.swap_remove(i);
} else {
i += 1;
}
}
// Push facets.
// TODO: can we avoid the tmp vector `new_facets` ?
triangles.append(&mut new_facets);
}
#[cfg(test)]
mod test {
use crate::transformation;
#[cfg(feature = "dim2")]
use na::Point2;
#[cfg(feature = "dim2")]
#[test]
fn test_simple_convex_hull() {
let points = [
Point2::new(4.723881f32, 3.597233),
Point2::new(3.333363, 3.429991),
Point2::new(3.137215, 2.812263),
];
let chull = transformation::convex_hull(points.as_slice());
assert!(chull.coords.len() == 3);
}
#[cfg(feature = "dim3")]
#[test]
fn test_ball_convex_hull() {
use crate::shape::Ball;
// This triggered a failure to an affinely dependent facet.
let (points, _) = Ball::new(0.4).to_trimesh(20, 20);
let (vertices, _) = transformation::convex_hull(points.as_slice());
// dummy test, we are just checking that the construction did not fail.
assert!(vertices.len() == vertices.len());
}
}